fix: enable attribute for all resources (#22)

* fix: enable attribute for all resources * fix: Update workflows tag --------- Co-authored-by: Archit Chopra <[email protected]>
clouddrove · Oct 3, 2023 · 46cd712 · 46cd712
1 parent 3e4cb09
commit 46cd712
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/auto_assignee.yml b/.github/workflows/auto_assignee.yml
@@ -5,7 +5,7 @@ on:
   workflow_dispatch:
 jobs:
   assignee:
-    uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@master
+    uses: clouddrove/github-shared-workflows/.github/workflows/auto_assignee.yml@1.0.6
     secrets:
       GITHUB: ${{ secrets.GITHUB }}
     with:

diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -7,7 +7,7 @@ on:
   workflow_dispatch:
 jobs:
   changelog:
-    uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@master
+    uses: clouddrove/github-shared-workflows/.github/workflows/changelog.yml@1.0.6
     secrets: inherit
     with:
       branch: 'master'
diff --git a/.github/workflows/readme.yml b/.github/workflows/readme.yml
@@ -17,7 +17,7 @@ jobs:
           python-version: '3.x'
 
       - name: 'create readme'
-        uses: 'clouddrove/github-actions@v9.0.2'
+        uses: 'clouddrove/github-actions@9.0.3'
         with:
           actions_subcommand: 'readme'
           github_token: '${{ secrets.GITHUB }}'
@@ -34,7 +34,7 @@ jobs:
         continue-on-error: true
 
       - name: 'push readme'
-        uses: 'clouddrove/github-actions@v9.0.2'
+        uses: 'clouddrove/github-actions@9.0.3'
         continue-on-error: true
         with:
           actions_subcommand: 'push'

diff --git a/.github/workflows/tf-checks.yml b/.github/workflows/tf-checks.yml
@@ -6,6 +6,6 @@ on:
   workflow_dispatch:
 jobs:
   example:
-    uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
+    uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@1.0.6
     with:
       working_directory: './_example/'
diff --git a/.github/workflows/tflint.yml b/.github/workflows/tflint.yml
@@ -6,6 +6,6 @@ on:
   workflow_dispatch:
 jobs:
   tf-lint:
-    uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@master
+    uses: clouddrove/github-shared-workflows/.github/workflows/tf-lint.yml@1.0.6
     secrets:
       GITHUB: ${{ secrets.GITHUB }}
diff --git a/.github/workflows/tfsec.yml b/.github/workflows/tfsec.yml
@@ -5,7 +5,7 @@ on:
   workflow_dispatch:
 jobs:
   tfsec:
-    uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@master
+    uses: clouddrove/github-shared-workflows/.github/workflows/tfsec.yml@1.0.6
     secrets: inherit
     with:
       working_directory: '.'
diff --git a/main.tf b/main.tf
@@ -95,7 +95,7 @@ resource "tls_locally_signed_cert" "root" {
 ## aws_acm_certificate. The ACM certificate resource allows requesting and management of certificates from the Amazon Certificate Manager..
 ##-----------------------------------------------------------------------------
 resource "aws_acm_certificate" "root" {
-  count             = var.certificate_enabled ? 1 : 0
+  count             = var.enabled && var.certificate_enabled ? 1 : 0
   private_key       = join("", tls_private_key.server[*].private_key_pem)
   certificate_body  = join("", tls_locally_signed_cert.root[*].cert_pem)
   certificate_chain = join("", tls_self_signed_cert.ca[*].cert_pem)
@@ -231,7 +231,7 @@ resource "aws_security_group" "this" {
 ## Provides network associations for AWS Client VPN endpoints.
 ##-----------------------------------------------------------------------------
 resource "aws_ec2_client_vpn_network_association" "default" {
-  count                  = length(var.subnet_ids)
+  count                  = var.enabled ? length(var.subnet_ids) : 0
   client_vpn_endpoint_id = join("", aws_ec2_client_vpn_endpoint.default[*].id)
   subnet_id              = element(var.subnet_ids, count.index)
 }
@@ -260,7 +260,7 @@ resource "aws_cloudwatch_log_stream" "vpn" {
 ## Provides authorization rules for AWS Client VPN endpoints.
 ##-----------------------------------------------------------------------------
 resource "aws_ec2_client_vpn_authorization_rule" "vpn_auth" {
-  count                  = length(var.network_cidr)
+  count                  = var.enabled ? length(var.network_cidr) : 0
   client_vpn_endpoint_id = join("", aws_ec2_client_vpn_endpoint.default[*].id)
   target_network_cidr    = element(var.network_cidr, count.index)
   authorize_all_groups   = var.authorize_all_groups
@@ -270,7 +270,7 @@ resource "aws_ec2_client_vpn_authorization_rule" "vpn_auth" {
 ## Provides authorization rules for AWS Client VPN endpoints.
 ##-----------------------------------------------------------------------------
 resource "aws_ec2_client_vpn_authorization_rule" "vpn_group_auth" {
-  count                  = length(var.group_ids)
+  count                  = var.enabled ? length(var.group_ids) : 0
   client_vpn_endpoint_id = join("", aws_ec2_client_vpn_endpoint.default[*].id)
   target_network_cidr    = element(var.target_network_cidr, count.index)
   access_group_id        = element(var.group_ids, count.index)
@@ -280,7 +280,7 @@ resource "aws_ec2_client_vpn_authorization_rule" "vpn_group_auth" {
 ## Provides additional routes for AWS Client VPN endpoints.
 ##-----------------------------------------------------------------------------
 resource "aws_ec2_client_vpn_route" "vpn_route" {
-  count                  = length(var.route_cidr)
+  count                  = var.enabled ? length(var.route_cidr) : 0
   client_vpn_endpoint_id = join("", aws_ec2_client_vpn_endpoint.default[*].id)
   destination_cidr_block = element(var.route_cidr, count.index)
   target_vpc_subnet_id   = element(var.route_subnet_ids, count.index)