Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing text/null variants that should have been otherwise #771

Closed
wants to merge 10 commits into from

Conversation

theferrit32
Copy link
Contributor

There were previously some CNVs that should have been normalized to CNV instead of Text given current capabilities of the normalization service.

Some will remain as Text until these are resolved:

Resolves #748

Touches #698

@theferrit32 theferrit32 added the clinvar Clinvar data exchange and reporting label May 8, 2023
@theferrit32 theferrit32 self-assigned this May 8, 2023
@theferrit32
Copy link
Contributor Author

Closing as Obsolete. We have extracted the variation transformation code into a separate repo here: https://github.com/clingen-data-model/clinvar-gk-pilot

When we come back to this we can take a look at if any code can be lifted over, but I think we want to minimize interaction with the normalization service and instead go through the native python library.

@theferrit32 theferrit32 closed this Mar 5, 2024
@theferrit32 theferrit32 added the wontfix This will not be worked on label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clinvar Clinvar data exchange and reporting wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some variation descriptors do not have a variant
1 participant