Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable creation of service file with init_style => 'unmanaged'. #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable creation of service file with init_style => 'unmanaged'. #123

wants to merge 2 commits into from

Conversation

natemccurdy
Copy link

Prior to this, it was impossible to override or disable the creation of
the consul-template service's init/service/unit file.

After this, the creation of the service file can be turned off by
setting the init_style parameter to unmanaged.

This is the same pattern used by the other commonly used Consul module, solarkennedy/puppet-consul:

https://github.com/solarkennedy/puppet-consul/blob/03f7f222fc7d5eab0ca875479b005731f0317e30/manifests/config.pp#L35

@natemccurdy
Copy link
Author

natemccurdy commented Apr 17, 2019

The Travis builds were failing due to a Ruby version incompatibility with Puppet 4 and how PDK creates the .travis.yml file.

I fixed it by updating PDK to 1.10.0 and setting a custom set of build configs based on an older version of PDK that still had support for Puppet 4.

Prior to this, it was impossible to override or disable the creation of
the consul-template service's init/service/unit file.

After this, the creation of the service file can be turned off by
setting the init_style parameter to `unmanaged`.
@natemccurdy
Copy link
Author

This fixes issue #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant