Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #192 via nested and remove using #196

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

ckormanyos
Copy link
Owner

No description provided.

@ckormanyos
Copy link
Owner Author

Ooops. I had inadvertently deleted the branch of a running CI/PR. This should correct that.

@ckormanyos
Copy link
Owner Author

Hi @johnmcfarlane this wraps up the first phase of clang-tidy fixes. I really wanted all (that I could detect) of modernize-* --- which is now in theis PR.

I am actually going to (from this point) hold off on further CT activities until you make a drive forward on that. There is no hurry for this and this serves to simply inform that I'm at a stable equilibrium at the moment and wait until you move forward. If/when that occurs, I'll sync up with your removal of CT exceptions.

This PR, I believe, gets wide-integer and all its test and example code CT-tidy with the exceptions:

  *,
  -altera-id-dependent-backward-branch,
  -altera-struct-pack-align,
  -altera-unroll-loops,
  -fuchsia-*,
  -llvmlibc-*,
  -llvm-header-guard,
  -readability-avoid-const-params-in-decls

@ckormanyos ckormanyos merged commit 1c8778c into master Jan 22, 2022
@ckormanyos ckormanyos deleted the tidy_namespaces branch January 22, 2022 11:02
@ckormanyos
Copy link
Owner Author

ckormanyos commented Jan 22, 2022

After this, I'll look into #194 and #183 and #169, and after all that finally re-visit #91

Cc: @johnmcfarlane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant