add no overwrite feature #9
Conversation
src/filepass/filepass.py
Outdated
| # No overwrite feature | ||
| # Check the environment variable status and if the file exists | ||
| if file_overwrite.upper() == "NO" and to_fs.exists(path): | ||
| try: |
There was a problem hiding this comment.
Rather than using an exception to break the loop and continue code something like below might work,
I think something like this would also prevent output form lines 167-168 (which are probably irrelevant in this case)
and the debug output should change a little because it might not all files not being transferred but just specific ones not transferred because of overwriting.
logger.debug(
f"File overwrite is disabled. \nFile {path} not transferred"
)
break
There was a problem hiding this comment.
@orlund Hey Orlund, so break stops the entire for loop and does not allow the code to execute further. I have used pass instead.
Testing was successful as well:
smb://svc_bank_recon_jde:[email protected]:445/groups/OWIFACE/bank_reconciliation_to_jde/jde_test/
sftp://filepass:[email protected]:22/u01/jdedwards/e910/PY910/import/
Establishing smb connection from server: dept-fs-pv03.ad.kamloops.city
Directory: /OWIFACE/bank_reconciliation_to_jde/jde_test/
Establishing sftp connection from server: jdeenttsvr.kamloops.city
Directory: /u01/jdedwards/e910/PY910/import/
File to move: /bank_recon_test.txt
No delete (to): /bank_recon_test.txt
No delete (from): /bank_recon_test.txt
File to move: /bank_recon_test2.txt
No delete (to): /bank_recon_test2.txt
File overwrite is disabled.
File /bank_recon_test2.txt not transferred
File to move: /bank_recon_test3.txt
No delete (to): /bank_recon_test3.txt
No delete (from): /bank_recon_test3.txt
Add no-file overwrite feature, check if the feature is enable/disabled and if the file in question exists on the destination server.