Merge pull request #62 from cityofaustin/1.0.11

Fix Record __repr__ to handle nonetype case
cityofaustin · Aug 20, 2020 · cbe917f · cbe917f
2 parents f56d922 + 6dafd4b
commit cbe917f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/coverage.svg b/coverage.svg
diff --git a/docs/developer_guide.md b/docs/developer_guide.md
@@ -51,7 +51,7 @@ After running the tests, you can use `$ coverage html` to generate HTML document
 You can update the coverage badge image with:
 
 ```bash
-$ coverage-badge -o coverage.svg
+$  coverage-badge -f -o coverage.svg
 ```
 
 ## Linting and Formatting

diff --git a/knackpy/record.py b/knackpy/record.py
@@ -23,9 +23,7 @@ def __init__(self, data, field_defs, identifier, timezone):
         self.immutable = True
 
     def __repr__(self):
-        identifier_value = self.data[self.identifier]
-        # if the identifier field has no value, use the record ID
-        identifier_value = identifier_value if identifier_value else self.data["id"]
+        identifier_value = self.data[self.identifier] if self.identifier else self.data["id"]
         return f"<Record '{identifier_value}'>"
 
     def __getitem__(self, client_key):

diff --git a/setup.py b/setup.py
@@ -46,7 +46,7 @@ def build_config(env, readme="README.md"):
         "packages": ["knackpy"],
         "tests_require": ["pytest", "coverage"],
         "url": "http://github.com/cityofaustin/knackpy",
-        "version": "1.0.10",
+        "version": "1.0.11",
     }