prevent TemplateProcessor context from overwritting #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffhendrey
approved these changes
Jan 22, 2024
| @@ -127,7 +127,7 @@ export default class CliCore { | |||
| } else { // if we are re-initializing, we need to reset the tagSet and options, if provided | |||
| this.templateProcessor.tagSet = new Set(); | |||
| this.templateProcessor.options = options; | |||
| if (contextData) { | |||
| if (contextData && Object.keys(contextData).length > 0) { | |||
There was a problem hiding this comment.
no biggie, but by the code, contextData appears it would never be undefined since it defaults to {} when no contextFilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug was blocking using a custom TemplateProcessor with a context from StatedREPL. I.e.
Adds a test to validate the fix.
Type of Change
Checklist