Bind context functions #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2023 16:06
geoffhendrey
requested changes
Nov 16, 2023
geoffhendrey
requested changes
Nov 16, 2023
src/TemplateProcessor.ts
Outdated
| @@ -179,7 +181,7 @@ export default class TemplateProcessor { | |||
| this.changeCallbacks = new Map(); | |||
| } | |||
|
|
|||
| private setupContext(context: {}) { | |||
| private setupContext(context: {}): void { | |||
| this.context = merge( | |||
There was a problem hiding this comment.
return merged value. Don't assign to this.context!
|
After discussions, this approach was found flawed and replaced with #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bind context function to TemplateProcessor instance, so they can access template processor methods, like setData.
Type of Change
Checklist