misc+doc: patch file for pytorch's nccl support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungjin
force-pushed
the
torch_nccl
branch
6 times, most recently
from
eba3baa to
45eb90e
Compare
This patch file updates the ncclResult_t type. ncclRemoteError code is added since nccl v2.13.4. In pytorch's code, the code is not updated. This causes the Unconvertible NCCL type error when a remote worker terminates or crashes. Also, 'AutoNcclGroup nccl_group_guard' is removed to allow 'TORCH_NCCL_ASYNC_ERROR_HANDLING = 2 (CleanUpOnly)' to work. with nccl_group_guard, a new exception is thrown while another exception is propagating, which causes the termination of the process in c++. To make CleanUpOnly possible, this guard is removed. The details on this patch are also documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch file updates the ncclResult_t type. ncclRemoteError code is added since nccl v2.13.4. In pytorch's code, the code is not updated. This causes the Unconvertible NCCL type error when a remote worker terminates or crashes.
Also, 'AutoNcclGroup nccl_group_guard' is removed to allow 'TORCH_NCCL_ASYNC_ERROR_HANDLING = 2 (CleanUpOnly)' to work. with nccl_group_guard, a new exception is thrown while another exception is propagating, which causes the termination of the process in c++. To make CleanUpOnly possible, this guard is removed.
The details on this patch are also documented.
Type of Change
Checklist