Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igp graph processor #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Igp graph processor #81

wants to merge 5 commits into from

Conversation

brmcdoug
Copy link
Collaborator

Description

The igp graph processor functions similar to the linkstate-edge processor, with an ultimate goal of creating a pair of graph/edge-collections, one for the entire IPv4 link state topology and one for the entire IPv6 link state topology. The processor first copies all ls_nodes into a new ls_node_extended collection. It then de-duplicates ISIS level-1-2 entries (BGP-LS creates both a level-1 and a level-2 entry for the same individual router). After de-duplication the processor mines ls_prefix and ls_srv6_sid datasets and attaches relevant SR/SRv6 SIDs to nodes in ls_node_extended. Finally the processor performs data correlation creating graphDB edge entries for nodes, links, and ls_prefixes.

The processor also registers "IGP Domains" in a new data collection. This will become useful for interconnecting multiple BGP-connected domains in the graph when a new BGP Processor is added

Type of Change

  • Bug Fix
  • [X ] New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • [X ] I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • [X ] I have verified this change is not present in other open pull requests
  • [X ] Functionality is documented
  • All code style checks pass
  • [X ] New code contribution is covered by automated tests
  • [X ] All new and existing tests pass

Copy link
Collaborator

@sbezverk sbezverk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit rusty on topology building logic, but one general recommendation. It is good approach to maintain modularity, meaning each processor does not define the same set of functions example like kafka notification, which should be pretty much the same for all porocessors, but reuse a common library of these artifacts. Imagine if you find a bug or need to change something ion the kafka messenger, with current approach you will need to visit bunch of source file to apply the same change. If you use a common library you change in a single place. Try to check processors and group common function into a separate package and import it where ever you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants