Dependencies Upgrade 2024-08 #428
Conversation
PR Verification Succeeded: Coverage >= |
| @@ -48,7 +48,7 @@ func ExternalImportsFromFormat(element interface{}) (result []string) { | |||
|
|
|||
| func MatchesFormat(element interface{}, specificType string) bool { | |||
| schema, err := ConvertToSchemaRef(element) | |||
| if err != nil && schema.Value.Type != openapi3.TypeString { | |||
| if err != nil || schema == nil || schema.Value.Type == nil || !schema.Value.Type.Is(openapi3.TypeString) { | |||
| if isInvalidReplace(&v) { | ||
| ret = append(ret, &v) | ||
| ret = append(ret, &mod.Replace[i]) |
There was a problem hiding this comment.
the github action annotation is referring to the original code on line 154, right?
There was a problem hiding this comment.
This is just a bug fix that brought to my attention after I enabled linters on /cmd.
If you are asking about the github-action output format for tests, it's in .github/actions/verify/action.yml, and it's already in main
| @@ -73,7 +73,7 @@ func generateNameFromRegex(regex string) string { | |||
| } | |||
| } | |||
|
|
|||
| hashedString := strings.ToUpper(fmt.Sprintf("%x", md5.Sum([]byte(regex))))[0:5] | |||
| hashedString := strings.ToUpper(fmt.Sprintf("%x", sha256.Sum224([]byte(regex))))[0:5] | |||
There was a problem hiding this comment.
linter, use of md5 result in lint issue
| opts = append([]config.LoadOptionsFunc{WithBasicProperties(p)}, opts...) | ||
| cfg, e := LoadConfig(ctx, opts...) | ||
| if e != nil { | ||
| return nil, fmt.Errorf(`unable to prepare for STS credentials`) | ||
| } | ||
|
|
||
| overrides := []ConfigOverrideFunc{OverrideConfigWithProperties(p)} |
There was a problem hiding this comment.
Is this code block redundant? NewStsCredentialsProvider is called by WithCredentialsProperties, which is called by PropertiesBasedConfigLoader.Load. And PropertiesBasedConfigLoader.Load does this override as well.
There was a problem hiding this comment.
not redundant. NewStsCredentialsProvider uses different aws.Config instance, because STS config is required before global aws.Config can be loaded. Without this, the corresponding test fails.
Description
Upgrade Go and Nodejs dependencies.
Notes:
github.com/jackc/pgproto3/[email protected]since this version have breaking changes. This lib is only used bycockroachdb/copyistwhich is test only and should have no impact on any production code.Upgraded Go Modules
(*) Higher version available with potential breaking changes
Type of Change
Checklist