Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the bump_version.sh script #377

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Oct 3, 2024

🗣 Description

This pull request replaces the existing bump_version.sh script with the updated bump-version script.

💭 Motivation and context

This modernizes the script that manages versions in our Packer projects.

🧪 Testing

Automated tests pass. I verified that ./bump-version show works as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 3, 2024
@mcdonnnj mcdonnnj requested a review from a team October 3, 2024 18:36
@mcdonnnj mcdonnnj self-assigned this Oct 3, 2024
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k added this pull request to the merge queue Dec 9, 2024
@jsf9k jsf9k removed this pull request from the merge queue due to a manual request Dec 9, 2024
@jsf9k jsf9k added this pull request to the merge queue Dec 10, 2024
@jsf9k jsf9k removed this pull request from the merge queue due to a manual request Dec 10, 2024
@jsf9k jsf9k added this pull request to the merge queue Dec 10, 2024
@jsf9k jsf9k removed this pull request from the merge queue due to a manual request Dec 10, 2024
Copy over necessary changes from the `bump_version.sh` script.
This functionality has been replaced by the `bump-version` script.
@jsf9k jsf9k force-pushed the improvement/update_bump_version_script branch from 85002aa to 8c2b384 Compare December 10, 2024 14:02
@jsf9k jsf9k enabled auto-merge December 10, 2024 14:03
@jsf9k jsf9k added this pull request to the merge queue Dec 10, 2024
@jsf9k jsf9k removed this pull request from the merge queue due to a manual request Dec 10, 2024
@jsf9k jsf9k added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit a54a55d Dec 10, 2024
14 checks passed
@jsf9k jsf9k deleted the improvement/update_bump_version_script branch December 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants