Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphabetize parts of the the Terraform configurations #279

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Alphabetize parts of the the Terraform configurations #279

merged 4 commits into from
Oct 27, 2023

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request alphabetizes attributes in the two Terraform configurations in this project.

Note

I am not bumping the version because these changes are purely cosmetic.

💭 Motivation and context

We prefer to alphabetize lists/map keys whenever possible.

🧪 Testing

Automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation terraform Pull requests that update Terraform code labels Oct 24, 2023
@mcdonnnj mcdonnnj self-assigned this Oct 24, 2023
dav3r
dav3r approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔤

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Oct 27, 2023
@mcdonnnj
Alphabetize backend configuration arguments
1385a6a 
This updates the two Terraform configurations in this repository so
that any AWS S3 backend configurations have a configuration sorted
alphabetically.
@mcdonnnj
Ensure all provider arguments are sorted alphabetically
65caa9f
@mcdonnnj
Ensure all tag map keys are sorted alphabetically
222a8b6 
This mainly brings the Terraform configuration into alignment with the
Packer configuration.
@mcdonnnj
Ensure all variable attributes are sorted alphabetically
96655af 
This mainly brings the Terraform configuration into alignment with the
Packer configuration.
@mcdonnnj mcdonnnj force-pushed the improvement/alphabetization branch from 8e78f79 to 96655af Compare October 27, 2023 06:55
@mcdonnnj mcdonnnj added this pull request to the merge queue Oct 27, 2023
Merged via the queue into develop with commit faf6cdf Oct 27, 2023
10 checks passed
@mcdonnnj mcdonnnj deleted the improvement/alphabetization branch October 27, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release terraform Pull requests that update Terraform code
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r