#3075 Adjustments to action td on tables - [NL]

[CocoByte]

Ticket

Resolves #00

Changes

• Widescreen width reduced from 1920px to 1536px
• Action column added to Members table.
• Action column width reduced to provide visual sense of right-alignment. Wrapping adjusted accordingly. The width is not static, but is more constricted than before.
• Alignment of icons in Action column adjusted to be vertically center-aligned with text

Context for reviewers

The ACs for this ticket were slightly modified during talks with design. Modifications are as follows;

• Instead of restricting Action column to 80px, which would cut off "Manage" hyperlinks and permanently wrap kebobs, the column shrinks down to either 80px or to its contents. The kebab is set to never wrap underneath.
• Requested width of the tables was determined to be 1536px and design verified visual adjustments.
• New AC for aligning kebab and gear icons vertically with text was included in this ticket

Setup

Code Review Verification Steps

Verify the following for all org/non-org tables

• Action columns are smaller
• Icons under action columns are vertically aligned with text
• Action column is added to Members table

As the original developer, I have

Satisfied acceptance criteria and met development standards

• Met the acceptance criteria, or will meet them in a subsequent PR
• Created/modified automated tests
• Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

• If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
• Interactions with external systems are wrapped in try/except
• Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

• Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
• Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

• Pulled this branch locally and tested it
• Verified code meets all checks above. Address any checks that are not satisfied
• Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
• Checked that all code is adequately covered by tests
• Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

• New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Meets all designs and user flows provided by design/product
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

• Checked that the design translated visually
• Checked behavior. Comment any found issues or broken flows.
• Checked different states (empty, one, some, error)
• Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• Tested with multiple browsers (check off which ones were used)
  • Chrome
  • Microsoft Edge
  • FireFox
  • Safari
• (Rarely needed) Tested as both an analyst and applicant user

References

• Code review best practices

Screenshots

[github-actions]

🥳 Successfully deployed to developer sandbox nl.