#3280: Review member permissions in registrar [LITTERBOX] #3325

zandercymatics · 2025-01-10T16:23:10Z

Ticket

Resolves #3280

Changes

On Members page (table): Changes the usa-tag "ADMIN" to be "Admin", color to primary-dark, and font weight to 600
On Members page (table): Displays the show assigned domains button on the member table in all cases when the user has domains
On Members page (table): Change "Last Active" column header to "Last active"
On Members page (table): Change font sizes to caption text size, non-blue sections are now base-dark, fixed grammar when a member is only assigned to one domain
Removed last row bottom border
On remove a member modal: Changed modal heading text, changed button collor to error 50, removed extra top padding
Alert on members page: Left-aligned and changed link text to primary blue
Members table (accessibility): Changed aria label for the expand buttons
Members table (accessibility): Changed aria label for kebab buttons
Members table (accessibility): Changed aria label for more options
Table (accessibility): Fixed tab order on table, added aria-live
Domain assignments page: Fixed h1, p, and h2 spacing for breadcrumb, header, and table
Edit domain assignments page: Fixed h1, p, and h2 spacing for breadcrumb, header, and table. Made p description span the width of the table.
Review domain assignments page: Fixed spacing, auto alphabetize list
Go to top of page when clicking the review button

Context for reviewers

Most of the changes in this PR impact the member table, so that is a good place to start. The other two locations this hits are on the edit member domains table and the member domains table.

Setup

You will need to test the following:

The members table
The edit member domains table
The member domains table

Basically, all the changes denoted above will need to be tested. Given the volume of smaller changes, I would recommend doing this via a huddle as that would be more efficient. You will need to be in portfolio mode with the organization_members flag enabled.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

github-actions · 2025-01-10T16:27:31Z

🥳 Successfully deployed to developer sandbox litterbox.

Addresses these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918173911589 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918609387289

github-actions · 2025-01-15T17:07:17Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-15T17:07:39Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-15T17:47:11Z

🥳 Successfully deployed to developer sandbox litterbox.

Resolves these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918783309229 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736919499797869

github-actions · 2025-01-15T18:02:57Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-15T20:08:10Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-16T18:27:11Z

🥳 Successfully deployed to developer sandbox litterbox.

This reverts commit f775818.

github-actions · 2025-01-16T18:39:45Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-16T18:46:36Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-16T19:29:58Z

🥳 Successfully deployed to developer sandbox litterbox.

Resolves these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134527341909 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134849047369 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737135619248379

https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134849047369

github-actions · 2025-01-27T22:23:21Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-27T22:37:48Z

🥳 Successfully deployed to developer sandbox litterbox.

src/registrar/assets/src/js/getgov/table-member-domains.js

github-actions · 2025-01-28T15:48:48Z

🥳 Successfully deployed to developer sandbox litterbox.

Pain

github-actions · 2025-01-28T15:53:02Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-28T15:55:49Z

🥳 Successfully deployed to developer sandbox litterbox.

zandercymatics · 2025-01-28T16:04:43Z

@rachidatecs Ready for re-review

github-actions · 2025-01-28T16:07:02Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-28T16:35:55Z

🥳 Successfully deployed to developer sandbox litterbox.

rachidatecs

Address last comments and conditionally approved.

rachidatecs · 2025-01-28T18:19:31Z

src/registrar/assets/src/js/getgov/table-member-domains.js

@@ -18,10 +18,11 @@ export class MemberDomainsTable extends BaseTable {
  addRow(dataObject, tbody, customTableOptions) {
    const domain = dataObject;
    const row = document.createElement('tr');
+    row.setAttribute("tabindex", "0"); 


I get that, but why do we need to tab through static table rows in the first place? This seems unnecessary, therefore should not be done?

src/registrar/assets/src/js/getgov/table-members.js

src/registrar/fixtures/fixtures_users.py

src/registrar/assets/src/sass/_theme/_admin.scss

src/registrar/assets/src/sass/_theme/_tables.scss

src/registrar/assets/src/sass/_theme/_usa-modal.scss

src/registrar/assets/src/sass/_theme/styles.scss

github-actions · 2025-01-28T21:44:31Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-28T21:49:37Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-28T21:59:59Z

🥳 Successfully deployed to developer sandbox litterbox.

github-actions · 2025-01-28T22:07:53Z

🥳 Successfully deployed to developer sandbox litterbox.

zandercymatics added 2 commits January 10, 2025 08:43

Change admin tag color, weight, and casing

5c127ed

Always show the "view assigned domains" link

ac02755

zandercymatics requested a review from abroddrick as a code owner January 10, 2025 16:23

zandercymatics changed the title ~~[draft] #3280: Review member permissions in registrar~~ [draft] #3280: Review member permissions in registrar - LITTERBOX Jan 10, 2025

zandercymatics changed the title ~~[draft] #3280: Review member permissions in registrar - LITTERBOX~~ [draft] #3280: Review member permissions in registrar [LITTERBOX] Jan 10, 2025

zandercymatics added 2 commits January 15, 2025 09:11

Last active, small text, base-dark, "domain" vs "domains"

fc2c6b5

Addresses these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918173911589 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918609387289

Update table-members.js

af26a36

fix bug

32e5cfe

Fix last table row + modal changes

036c10e

Resolves these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736918783309229 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1736919499797869

Fix bugs

3aa493d

change kebab style

f775818

Revert "change kebab style"

ee4629b

This reverts commit f775818.

Fix error styling on member page

c8ac9c4

Update test_views_portfolio.py

f7c38e9

zandercymatics added 6 commits January 17, 2025 12:02

Add aria information

9cb6179

Resolves these: https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134527341909 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134849047369 https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737135619248379

Code cleanup

548953e

Update aria label for kebab on member page

eab7b79

https://cisa-corp.slack.com/archives/C087NN9UW5C/p1737134849047369

Fix table definition

0c3a2a5

Fix table tabbing

dfc9b47

Merge branch 'main' into litterbox/3280-design-review

91c1949

Cleanup css

6c074bd

Update email_invitations.py

e2c2813

asaki222 reviewed Jan 27, 2025

View reviewed changes

src/registrar/assets/src/js/getgov/table-member-domains.js Show resolved Hide resolved

zandercymatics added 4 commits January 28, 2025 08:21

Fix data-member bug

9b1d1d1

Attempt to fix border-bottom

241b43e

Update _tables.scss

b078149

Fix unit test

4dd9b99

Target ID rather than CLASS

477f9ce

Pain

Merge branch 'main' into litterbox/3280-design-review

3c3ce69

zandercymatics requested a review from rachidatecs January 28, 2025 16:04

Update table-members.js

e681f10

rachidatecs approved these changes Jan 28, 2025

View reviewed changes

Merge branch 'main' into litterbox/3280-design-review

ad2c04d

PR suggestions

e7243b7

Remove tabindex

d68a338

Merge branch 'main' into litterbox/3280-design-review

6f39eac

zandercymatics merged commit bc7bc4d into main Jan 28, 2025
10 checks passed

zandercymatics deleted the litterbox/3280-design-review branch January 28, 2025 22:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3280: Review member permissions in registrar [LITTERBOX] #3325

#3280: Review member permissions in registrar [LITTERBOX] #3325

zandercymatics commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

zandercymatics commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

rachidatecs left a comment

rachidatecs Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

#3280: Review member permissions in registrar [LITTERBOX] #3325

#3280: Review member permissions in registrar [LITTERBOX] #3325

Conversation

zandercymatics commented Jan 10, 2025 • edited Loading

Ticket

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

zandercymatics commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

rachidatecs left a comment

Choose a reason for hiding this comment

rachidatecs Jan 28, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

zandercymatics commented Jan 10, 2025 •

edited

Loading