Specify all variables as non-nullable
#843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3r
added
improvement
jsf9k
approved these changes
Nov 19, 2024
5 tasks
This means that we need not worry about whether variables are explicitly specified as null. Since this is not something we were expecting, it makes sense to avoid the situation. See also: https://developer.hashicorp.com/terraform/language/values/variables#disallowing-null-input-values Co-authored-by: Jeremy Frasier <[email protected]>
Version 1.1 of Terraform is the first version to support the nullable key in variable definitions. Co-authored-by: Jeremy Frasier <[email protected]>
dav3r
force-pushed
the
improvement/specify-tf-variables-as-non-nullable
branch
from
01c4656 to
94a2bfc
Compare
jsf9k
approved these changes
Nov 21, 2024
mcdonnnj
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request specifies all variables as non-
nullable.💭 Motivation and context
This means that we need not worry about whether variables are explicitly specified as
null. Since this is not something we were expecting, it makes sense to avoid the situation.See also the Terraform documentation.
This PR follows in the footsteps of cisagov/skeleton-tf-module#221.
Note that this PR was built on top of the changes in #838, which should be merged soon.The commits specific to this PR are:🧪 Testing
All automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.