Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update main.yml with linters and scanners #55

Closed
wants to merge 1 commit into from
Closed

Conversation

aarz-snl
Copy link
Collaborator

Update workflow to perform linting and security scans

🗣 Description

I have updated the pipeline with a workflow that includes some linting and security scanning.

Jobs will run the same as they have always run. Upon PR to main, upon commit to main. Release stage will only run upon creation of a new tag.

💭 Motivation and context

pipeline currently had place holders. This is so we actually starting linting / security scanning our scripts

🧪 Testing

Pipeline was tested in PRIV and you can review the results of the actions in this PR.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aarz-snl aarz-snl requested a review from mreeve-snl November 20, 2023 19:40
@llwaterhouse
Copy link
Contributor

I would like to save this PR for our December release. Please update the "commit into" branch from "main" to our next release branch. Thanks!

@aarz-snl
Copy link
Collaborator Author

Closing and will reopen with a PR to december release.

@aarz-snl aarz-snl closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants