tart pull: open the VM directory after pulling under a lock (#936)

cirruslabs · Nov 4, 2024 · f7b3876 · f7b3876
1 parent 7c1ed46
commit f7b3876
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Sources/tart/Commands/Pull.swift b/Sources/tart/Commands/Pull.swift
@@ -47,8 +47,5 @@ struct Pull: AsyncParsableCommand {
     defaultLogger.appendNewLine("pulling \(remoteName)...")
 
     try await VMStorageOCI().pull(remoteName, registry: registry, concurrency: concurrency, deduplicate: deduplicate)
-
-    // to explicitly set the image as being accessed so it won't get pruned immediately
-    _ = try VMStorageOCI().open(remoteName)
   }
 }
diff --git a/Sources/tart/VMStorageOCI.swift b/Sources/tart/VMStorageOCI.swift
@@ -239,6 +239,9 @@ class VMStorageOCI: PrunableStorage {
       // are excluded from garbage collection
       VMDirectory(baseURL: vmURL(name)).markExplicitlyPulled()
     }
+
+    // to explicitly set the image as being accessed so it won't get pruned immediately
+    _ = try VMStorageOCI().open(name)
   }
 
   func linked(from: RemoteName, to: RemoteName) -> Bool {