-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systray 2 #166
Systray 2 #166
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
Now that I'm actually using this, I've got two ideas:
Any ideas on how to deal with those issues? I don't really know much about tauri so maybe there's a feature here that could help. |
So I have been patiently following along for any sort of tray icon support because using Cinny on Desktop without it has been annoying. I just wanted to chime in and suggest that we don't scope creep. Is it absolutely necessary to toggle or configure the system tray at this point in time? System tray things can be hidden or ignored at the window manager level. It is not super urgent to get it in this PR, maybe it can come in a second PR later. To answer your questions @StevenDoesStuffs
just call that or equivalent on load if setting is set. Either way, we need to decide on scope, because there are tons of features and tickets relying on a system tray icon, or being able to run in the background with a hidden window. Minimize to systray on startup can be postponed to a later PR. Configuring the system tray usage can be done entirely through Desktop app menus at first if needed. |
Does what title says. Lifts event handler logic from paste image support (cinnyapp#167). Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
Does what title says. Lifts event handler logic from paste image support (cinnyapp#167). Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
to uncomment when cinnyapp#166 is merged.
Description
Same as #128, but with changes stolen from greentore#1.
Type of change
Checklist: