Pr/jrfastab/config map testing #3355
Closed
+67
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfastab
force-pushed
the
pr/jrfastab/config-map-testing
branch
2 times, most recently
from
d0043e0 to
028506f
Compare
jrfastab
added
the
release-note/misc
We currently do not have any test infrastructure to test systemd config options. Add a WithConfigMap primitive so we can start to test different deployments. Signed-off-by: John Fastabend <[email protected]>
To test passing config files and parsing options we need to expose the API for testing. Signed-off-by: John Fastabend <[email protected]>
This ensure config dir options are working. Signed-off-by: John Fastabend <[email protected]>
jrfastab
force-pushed
the
pr/jrfastab/config-map-testing
branch
from
028506f to
5fc4ff6
Compare
|
close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bug report that a config file option did not work when pushed through the config map as a file in systemd. It turned out to be a typo but this adds infrastructure and a test to add go tests to check this works.
For now I just add one test but we can add more easily now.