Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Add map_errors_update_total/map_errors_delete_total metrics #3346

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

olsajiri
Copy link
Contributor

Adding map_errors_update_total/map_errors_delete_total metrics, which replace current tetragon_map_errors_total.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 881a8be
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6798a904c147410008d5f4db
😎 Deploy Preview https://deploy-preview-3346--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Jan 28, 2025
@olsajiri olsajiri marked this pull request as ready for review January 28, 2025 12:09
@olsajiri olsajiri requested review from mtardy and a team as code owners January 28, 2025 12:09
@olsajiri olsajiri requested review from kkourt and lambdanis January 28, 2025 12:09
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 🙇‍♀️
Can you add an upgrade note contrib/upgrade-notes/latest.md for the metrics change? It's technically a breaking change.

At the moment we use '*_stats' maps (like execve_map_stats) to store
total count for master map (like execve_map) in array entry 0 and
errors in array entry 1 and that value now comprises both update
and delete errors.

This change separates separates update and delete errors to be able
to get metrics for update error in following change.

Atm this will touch 2 maps:
  execve_map_stats
  tg_execve_joined_info_map_stats

Signed-off-by: Jiri Olsa <[email protected]>
Adding map_errors_update_total/map_errors_delete_total metrics,
which replace current tetragon_map_errors_total.

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri merged commit db01c3d into main Jan 30, 2025
46 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/fixes branch January 30, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants