Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: replace panic with t.Fatal #3287

Merged
merged 3 commits into from
Jan 9, 2025
Merged

tests: replace panic with t.Fatal #3287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a2a58a
Test: Change panic to t.Fatal
kevsecurity Jul 17, 2024
9ba8e4f
pkg/sensors: rate limit test, avoid calling printf
mtardy Jul 18, 2024
a1c5438
vmtests: bump base image used to root-images:20240717.161638
mtardy Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/sensors/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestAddPolicy(t *testing.T) {
assert.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down Expand Up @@ -72,7 +72,7 @@ func TestAddPolicies(t *testing.T) {
assert.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down Expand Up @@ -103,7 +103,7 @@ func TestAddPolicySpecError(t *testing.T) {
assert.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down Expand Up @@ -135,7 +135,7 @@ func TestAddPolicyLoadError(t *testing.T) {
assert.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down Expand Up @@ -211,7 +211,7 @@ func TestPolicyStates(t *testing.T) {
require.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand All @@ -236,7 +236,7 @@ func TestPolicyStates(t *testing.T) {
require.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down Expand Up @@ -276,7 +276,7 @@ func TestPolicyLoadErrorOverride(t *testing.T) {
require.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})
policy.ObjectMeta.Name = "test-policy"
Expand Down
2 changes: 1 addition & 1 deletion pkg/sensors/tracing/generickprobe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func Test_Kprobe_DisableEnablePolicy(t *testing.T) {
assert.NoError(t, err)
t.Cleanup(func() {
if err := mgr.StopSensorManager(ctx); err != nil {
panic("failed to stop sensor manager")
t.Fatal("failed to stop sensor manager")
}
})

Expand Down
6 changes: 2 additions & 4 deletions pkg/sensors/tracing/kprobe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5842,15 +5842,13 @@ spec:
// Generate 5 datagrams
socket, err := net.Dial("udp", "127.0.0.1:9468")
if err != nil {
fmt.Printf("ERROR dialing socket\n")
panic(err)
t.Fatalf("failed dialing socket: %s", err)
}

for i := 0; i < 5; i++ {
_, err := socket.Write([]byte("data"))
if err != nil {
fmt.Printf("ERROR writing to socket\n")
panic(err)
t.Fatalf("failed writing to socket: %s", err)
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/vmtests/fetch-data.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -eu -o pipefail


OCIORG=quay.io/lvh-images
ROOTIMG=$OCIORG/root-images
ROOTIMG=$OCIORG/root-images:20240717.161638@sha256:62a9890111ab39749792fda4f59c8f736fa350ecaedb0667e3eecbbe790d82ed
KERNIMG=$OCIORG/kernel-images
CONTAINER_ENGINE=${CONTAINER_ENGINE:-docker}
KERNEL_VERS="$@"
Expand Down
Loading