Implemented a possibility to disable gops via helm

[XelK]

Fixes

Description

Implemented the possibility to disable gops server when installing tetragon via helm

Changelog

Add an "enabled" switch to enable/disable the gops server via the Helm chart. It is now disabled by default.

[mtardy]

Thanks for the patch following the discussion we had on Slack :)! However, it looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.

Concretely it consists of adding your real name and an email address to your git config and using git commit -s to write your commit message. You can use git commit --amend -s to add the signature to existing commits.

See more details on how to comply with the "sign-off" procedure

To add your name and email to your git config:

git config user.email "[email protected]"
git config user.name "firstname lastname"

Note: add the --global flag after config to configure this by default for repositories on your host.

Then you can use for new commits:

git commit -s

Or for existing commits on which you want to add the signed-off-by statement:

git commit --amend -s

For more information, see this extract from git-commit(1) man page regarding the -s flag:

-s, --signoff, --no-signoff
   Add a Signed-off-by trailer by the committer at the end of the commit log
   message. The meaning of a signoff depends on the project to which you're
   committing. For example, it may certify that the committer has the rights to
   submit the work under the project's license or agrees to some contributor
   representation, such as a Developer Certificate of Origin. (See
   http://developercertificate.org for the one used by the Linux kernel and Git
   projects.) Consult the documentation or leadership of the project to which
   you're contributing to understand how the signoffs are used in that project.

   The --no-signoff option can be used to countermand an earlier --signoff
   option on the command line.

[mtardy]

Hey, please take a look at the CI output to update your patch and please in the end squash your commits into only one :)! Thanks

[netlify]

✅ Deploy Preview for tetragon ready!

Name	Link
🔨 Latest commit	d439e0f
🔍 Latest deploy log	https://app.netlify.com/sites/tetragon/deploys/66fc3eea2291080008cb8d48
😎 Deploy Preview	https://deploy-preview-2961--tetragon.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mtardy]

It will be user-facing change however, I imagine that the previous situation was making this enabled by default. However I think disabling it by default might be correct indeed!

[mtardy]

it looks like e2e test is assuming gops is enabled by default

[mtardy]

Thanks a lot for the work, if you want we could maybe disable that by default, thus we would need small changes in the e2e test framework.