v0.10: update k8s #2134
Closed
v0.10: update k8s #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 76831cf ] cilium/cilium/pkg/alignchecker now uses map[string][]any as second argument to CheckStructAlignments so we have to pass the type directly instead of the reflect.TypeOf. For more details, see: cilium/cilium@e6d40ee Signed-off-by: Mahe Tardy <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
[ upstream commit 3f57a01 ] Added it to false even though it's not used anyway in the func (cache.ResourceEventHandlerFuncs).OnAdd(obj interface{}, isInInitialList bool) implementation. Signed-off-by: Mahe Tardy <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
[upstream commit 06780d2 ] We no longer need the special golangci-lint docker image since we now build without CGO and can use the upstream image directly. Secondly, this adds GOTOOLCHAIN=auto to the golangci-lint container since it might ship older Go toolchain than our go.mod directive and thus not being able to build the project. Signed-off-by: Mahe Tardy <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
[ upstream commit 3f4cc32 ] The default settings can hide existing issues until older ones are fixed, which leads to a really frustrating back-and-forth with CI trying to get all outstanding issues fixed. Signed-off-by: William Findlay <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
c0235fa to
b417fa0
Compare
Signed-off-by: Kornilios Kourtis <[email protected]>
Appease the great revive!
rant: I really dislike having to change code from:
if foo, err := fn1(); err != nil {
return err
} else if bar, err := foo.fn2(); err != nil {
return err
}
To:
foo, err := fn1()
if err != nil {
return err
}
...
I think the first version is better due to scoping.
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
b417fa0 to
ea8775c
Compare
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
ea8775c to
93c2941
Compare
[ upstream commit bbce04f ] Signed-off-by: William Findlay <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
93c2941 to
eab6182
Compare
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
eab6182 to
1a696b5
Compare
Signed-off-by: Kornilios Kourtis <[email protected]>
... and run make generate and make codegen Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
1a696b5 to
901b3a5
Compare
kkourt
had a problem deploying
to
release-clang
GitHub Actions
Failure
kkourt
had a problem deploying
to
release-clang
GitHub Actions
Failure
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/v0.10-update-k8s
branch
from
8e9da21 to
5885c55
Compare
kkourt
had a problem deploying
to
release-clang
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.