Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport/v0.10: bugtool gops pprofheap #2051

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

tixxdz
Copy link
Member

@tixxdz tixxdz commented Feb 1, 2024

No description provided.

[ Upstream master 36cae01 ]

Patch fixed to resolve conflicts.

This adds support to get or set the gops path.

Signed-off-by: Djalal Harouni <[email protected]>
[Upstream main bae3b77]

We use gops to get the pprof heap profile instead of http, as it seems
that gops does not export an HTTP endpoint, and by default we do not
start the pprof profiling server. The --pprof-addr is marked hidden
and requiring users to listen on another port could be an overkill.

Signed-off-by: Djalal Harouni <[email protected]>
[Upstream main 558d869]

Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz requested review from willfindlay and a team as code owners February 1, 2024 21:41
@tixxdz tixxdz added release-note/minor This PR introduces a minor user-visible change backport-done/0.10 labels Feb 1, 2024
@tixxdz tixxdz force-pushed the pr/tixxdz/backport-v0.10/bugtool-gops-pprofheap branch from 16266a9 to e504c8e Compare February 1, 2024 21:52
This introduces tarball tests for 0.10, also it tries to test
bugtool gops pprof-heap.

Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz force-pushed the pr/tixxdz/backport-v0.10/bugtool-gops-pprofheap branch from e504c8e to e15d5a1 Compare February 1, 2024 21:57
@tixxdz tixxdz merged commit f9bac6a into v0.10 Feb 6, 2024
19 checks passed
@tixxdz tixxdz deleted the pr/tixxdz/backport-v0.10/bugtool-gops-pprofheap branch February 6, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants