-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugtool: fetch gops pprof heap #2007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tixxdz
added
the
release-note/minor
This PR introduces a minor user-visible change
label
Jan 22, 2024
tixxdz
force-pushed
the
pr/tixxdz/gops-pprof-heap
branch
from
January 22, 2024 19:26
08b68e2
to
f0bd47d
Compare
tixxdz
changed the title
bugtool: allow read or set gops path
bugtool: fetch gops pprof heap
Jan 22, 2024
kkourt
reviewed
Jan 23, 2024
kkourt
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This adds support to get or set the gops path. Signed-off-by: Djalal Harouni <[email protected]>
We use gops to get the pprof heap profile instead of http, as it seems that gops does not export an HTTP endpoint, and by default we do not start the pprof profiling server. The --pprof-addr is marked hidden and requiring users to listen on another port could be an overkill. Signed-off-by: Djalal Harouni <[email protected]>
Signed-off-by: Djalal Harouni <[email protected]>
Signed-off-by: Djalal Harouni <[email protected]>
tixxdz
force-pushed
the
pr/tixxdz/gops-pprof-heap
branch
from
January 24, 2024 15:35
f0bd47d
to
bb0139c
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gops looks relatively small <10MB so should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-backport/1.0
This PR needs backporting to 1.0
release-note/minor
This PR introduces a minor user-visible change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.