Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugtool: fetch gops pprof heap #2007

Merged
merged 4 commits into from
Jan 26, 2024
Merged

bugtool: fetch gops pprof heap #2007

merged 4 commits into from
Jan 26, 2024

Conversation

tixxdz
Copy link
Member

@tixxdz tixxdz commented Jan 22, 2024

No description provided.

@tixxdz tixxdz requested a review from a team as a code owner January 22, 2024 13:54
@tixxdz tixxdz requested a review from kevsecurity January 22, 2024 13:54
@tixxdz tixxdz marked this pull request as draft January 22, 2024 13:54
@tixxdz tixxdz added the release-note/minor This PR introduces a minor user-visible change label Jan 22, 2024
@tixxdz tixxdz force-pushed the pr/tixxdz/gops-pprof-heap branch from 08b68e2 to f0bd47d Compare January 22, 2024 19:26
@tixxdz tixxdz changed the title bugtool: allow read or set gops path bugtool: fetch gops pprof heap Jan 22, 2024
@tixxdz tixxdz marked this pull request as ready for review January 22, 2024 19:26
@tixxdz tixxdz requested a review from willfindlay as a code owner January 22, 2024 19:26
@tixxdz tixxdz requested a review from jrfastab January 22, 2024 19:28
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pkg/bugtool/bugtool.go Outdated Show resolved Hide resolved
This adds support to get or set the gops path.

Signed-off-by: Djalal Harouni <[email protected]>
We use gops to get the pprof heap profile instead of http, as it seems
that gops does not export an HTTP endpoint, and by default we do not
start the pprof profiling server. The --pprof-addr is marked hidden
and requiring users to listen on another port could be an overkill.

Signed-off-by: Djalal Harouni <[email protected]>
Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz force-pushed the pr/tixxdz/gops-pprof-heap branch from f0bd47d to bb0139c Compare January 24, 2024 15:35
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit bb0139c
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65b12e47d10d7300085d5b81
😎 Deploy Preview https://deploy-preview-2007--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tixxdz tixxdz added the needs-backport/1.0 This PR needs backporting to 1.0 label Jan 26, 2024
@jrfastab
Copy link
Contributor

gops looks relatively small <10MB so should be ok.

@jrfastab jrfastab merged commit fff17c0 into main Jan 26, 2024
37 checks passed
@jrfastab jrfastab deleted the pr/tixxdz/gops-pprof-heap branch January 26, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport/1.0 This PR needs backporting to 1.0 release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants