Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add servicemonitor for operator #1836

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

hungran
Copy link
Contributor

@hungran hungran commented Dec 4, 2023

hi team,
this will fix the issue #1778

  • optional ServiceMonitor scraping operator metrics (similar to this one for the agent)
  • Don't start the operator metrics server if tetragonOperator.prometheus.enabled = false -> might need some advise on this ? should be a new flag that we can disable at here operator/cmd/serve/serve.go

@hungran hungran requested a review from a team as a code owner December 4, 2023 15:28
@hungran hungran requested a review from olsajiri December 4, 2023 15:28
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 6258243
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/656fe37746080c000774135b
😎 Deploy Preview https://deploy-preview-1836--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis added release-note/minor This PR introduces a minor user-visible change area/helm Related to the Helm chart labels Dec 4, 2023
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I requested one change to avoid creating the servicemonitor unnecessarily.

install/kubernetes/templates/operator_servicemonitor.yaml Outdated Show resolved Hide resolved
@hungran hungran force-pushed the hungran/ISSUE-1778/operator-metrics branch from b8701b0 to 0e1c8da Compare December 6, 2023 02:57
@hungran hungran force-pushed the hungran/ISSUE-1778/operator-metrics branch from 0e1c8da to 6258243 Compare December 6, 2023 02:59
@hungran hungran requested a review from lambdanis December 6, 2023 03:00
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lambdanis lambdanis merged commit 1092c7e into cilium:main Dec 6, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Related to the Helm chart release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants