-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Added various configuration options for the Tetragon Operator Deployment #1817
Helm: Added various configuration options for the Tetragon Operator Deployment #1817
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you.
I left one comment about labels configuration, but more like food for thought.
@PhilipSchmid I see the CI is failing:
Could you fix these? |
* Added support for dedicated SA for the Tetragon Operator * Fixed serviceAccount.name usage as it wasn't considered before Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
Signed-off-by: Philip Schmid <[email protected]>
54d5017
to
454d680
Compare
@lambdanis I just shortened the commit messages and checked that the |
Oh dear, it looks like some Quay hiccup maybe? The CI failures definitely don't looks related to the changes. I'll rerun. |
Ok, I run on your branch and it looks like the trailing space here is the problem. I suppose your editor is removing trailing spaces automatically? If you could remove this space from the script, then it should pass :) (a bit surprising that nobody hit it before tbh) |
7a8dc1e
to
aee72c3
Compare
Signed-off-by: Philip Schmid <[email protected]>
aee72c3
to
2aa5b16
Compare
After some flakes the CI finally passes, so I'm merging it, thank you @PhilipSchmid! |
I have added multiple configuration options for the Tetragon Operator Deployment, which are often crucial for enterprise-grade deployments that need to happen within certain security boundaries.
According to my current understanding, this should not break anything for existing users. The only chance I see a breakage happen is when somebody already configured
.Values.serviceAccount.name
in the past. The thing is, this value was never considered, and the SA was simply named{{ .Release.Name }}
or{{ .Release.Name }}-operator-service-account
. With this change, it would suddenly be considered for the actual SA naming.Fixes: #1761