Misc Helm updates #1814
Merged
Misc Helm updates #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they can use PodInfo goodness. Signed-off-by: Anna Kapuscinska <[email protected]>
It's templated already in clusterrolebinding. Signed-off-by: Anna Kapuscinska <[email protected]>
Adding podLabels Helm value, which allows the user to add custom labels to pods without overriding the default labels, like podLabelsOverride does. Overriding all labels required the user to specify correct selector labels too, so having an option to keep them is more convenient. Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#container-v1-core > [...] FallbackToLogsOnError will use the last chunk of container log > output if the termination message file is empty and the container > exited with an error. The log output is limited to 2048 bytes or 80 > lines, whichever is smaller. [...] Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
It seems it was templated in an incorrect place anyway (before the tag). Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
approved these changes
Nov 29, 2023
Comment on lines
-165
to
-166
| # tetragon-operator image-digest | ||
| suffix: "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.