Skip to content

Commit

Permalink
gh: validate crd: be less strict
Browse files Browse the repository at this point in the history
The validate CRD action checks two things: whether yaml files were
changed without the version being updated, and whether the version was
updated without changing the yaml files. There are legitimate reasons
for doing the second (e.g., when we do a releas and bump the minor
number) so remove the check.

Signed-off-by: Kornilios Kourtis <[email protected]>
  • Loading branch information
kkourt committed Dec 13, 2024
1 parent 863beac commit b681b88
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/validate-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,3 @@ jobs:
echo "Changes to the files pkg/k8s/apis/cilium.io/client/crds/v1alpha1/*.yaml requires CustomResourceDefinitionSchemaVersion to be updated in pkg/k8s/apis/cilium.io/v1alpha1/version.go"
exit 1
fi
if [ "$crd_changed" -eq 0 ] && [ "$version_changed" -eq 1 ]; then
echo "CustomResourceDefinitionSchemaVersion in pkg/k8s/apis/cilium.io/v1alpha1/version.go to be updated only in case of modifying the files pkg/k8s/apis/cilium.io/client/crds/v1alpha1/*.yaml"
exit 1
fi

0 comments on commit b681b88

Please sign in to comment.