eventmetrics: Rename tetragon_missed_events_total

There are a few places where events be "missed", so let's make it clear in the metric name that's it's counting kernel misses. Signed-off-by: Anna Kapuscinska <[email protected]>
cilium · Aug 27, 2024 · 17c5346 · 17c5346
1 parent fb06a51
commit 17c5346
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/contrib/upgrade-notes/latest.md b/contrib/upgrade-notes/latest.md
@@ -46,3 +46,4 @@ tetragon:
 
 * `tetragon_policyfilter_metrics_total` metric is renamed to `tetragon_policyfilter_operations_total`, and its `op`
   label is renamed to `operation`.
+* `tetragon_missed_events_total` metric is renamed to `tetragon_bpf_missed_events_total`.
diff --git a/docs/content/en/docs/reference/metrics.md b/docs/content/en/docs/reference/metrics.md
diff --git a/pkg/metrics/eventmetrics/collector.go → pkg/metrics/eventmetrics/bpfcollector.go b/pkg/metrics/eventmetrics/collector.go → pkg/metrics/eventmetrics/bpfcollector.go
diff --git a/pkg/metrics/eventmetrics/eventmetrics.go b/pkg/metrics/eventmetrics/eventmetrics.go
@@ -42,8 +42,8 @@ var (
 		ConstLabels: nil,
 	}, []string{"type"})
 	MissedEvents = metrics.MustNewCustomCounter(metrics.NewOpts(
-		consts.MetricsNamespace, "", "missed_events_total",
-		"The total number of Tetragon events per type that are failed to sent from the kernel.",
+		consts.MetricsNamespace, "bpf", "missed_events_total",
+		"Number of Tetragon perf events that are failed to be sent from the kernel.",
 		nil, []metrics.ConstrainedLabel{metrics.OpCodeLabel, perfEventErrorLabel}, nil,
 	))
 	FlagCount = prometheus.NewCounterVec(prometheus.CounterOpts{
Original file line number	Diff line number	Diff line change
Expand Up		@@ -46,3 +46,4 @@ tetragon:

		* `tetragon_policyfilter_metrics_total` metric is renamed to `tetragon_policyfilter_operations_total`, and its `op`
		label is renamed to `operation`.
		* `tetragon_missed_events_total` metric is renamed to `tetragon_bpf_missed_events_total`.