Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment updates #384

Closed
wants to merge 6 commits into from
Closed

Deployment updates #384

wants to merge 6 commits into from

Conversation

bayram-dev
Copy link

After getting error (#381) - tried to deploy it myself and got to some minor error.

  1. Outdated test results
  2. Libraries that have removed certain functionality, which is why the launch was not successful

So, i tried to fix it in someway

  1. Updated test results
  2. Fixed library version error (sort of workaround - just specified exact version, that used)
  3. Removed online tests (because of 500 Internal Server Error when send request to https://cht.sh/:shell-x/ #381 error couldn't gather any information)
  4. Updated alpine to 3.18 (Ubuntu Tests)

After all work got 20/20 tests passed and online tests remained untested.

Required packages with breaking changes (after fixing versions made it possible to deploy)
 - Werkzeug==0.16.1
 - MarkupSafe==2.0.1
Changed tests:
 - Switched `skip-online` to `YES` because of problems with current connection with cheat.sh
 - Updated outdated test results
@bayram-dev
Copy link
Author

bayram-dev commented Jun 7, 2023

Dont be scared of change number - most part of it just test results changes

Waiting for Igor's review

Strange behaviour commit was just testing commit, because of the difference between my local results and Github Actions

@bayram-dev
Copy link
Author

bayram-dev commented Jun 7, 2023

After some work, deployed it on actual server to test the results... And it works

https://ch.batagiev.ru/

@abitrolly
Copy link
Collaborator

I could review a separate PR with test fixes alone without touching libraries and changing config. Even if some of them fail.

@bayram-dev bayram-dev closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants