Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment secrets for Codecov token #1596

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Use environment secrets for Codecov token #1596

merged 1 commit into from
Jul 8, 2024

Conversation

djc
Copy link
Member

@djc djc commented Jul 8, 2024

It seems like there are some unexpected differences between "Repository secrets" and "Environment secrets" for GitHub repositories. In another repo, this seemed to help. (I've copied the token into the new Environment.)

@djc djc requested a review from pitdicker July 8, 2024 09:40
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (51c2d4b) to head (9ff8ba0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1596      +/-   ##
==========================================
- Coverage   91.78%   91.75%   -0.04%     
==========================================
  Files          37       37              
  Lines       18207    18207              
==========================================
- Hits        16712    16706       -6     
- Misses       1495     1501       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker
Copy link
Collaborator

We can't easily test this I think? What do you think about adding it as a commit to #1594?

@djc
Copy link
Member Author

djc commented Jul 8, 2024

It worked in this PR, right? Can rebase #1594 on top of this after it merges -- it certainly doesn't make anything worse.

@pitdicker pitdicker merged commit 4401f39 into main Jul 8, 2024
35 checks passed
@pitdicker pitdicker deleted the env-secret branch July 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants