0.5.x: Remove everything deprecated

[pitdicker]

Remove everything that is deprecated on the 0.5 branch.

I was wondering if it was better to rename the replacement methods at the same time as removing the deprecated methods, or to leave that for another PR. I.e. renaming things like FixedOffset::east_opt to FixedOffset::east.

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6e8c150) 93.51% compared to head (69a665f) 94.16%.
Report is 1 commits behind head on 0.5.x.

Files	Patch %	Lines
src/datetime/mod.rs	90.90%	2 Missing ⚠️
src/datetime/serde.rs	95.45%	1 Missing ⚠️
src/format/parsed.rs	92.85%	1 Missing ⚠️
src/naive/datetime/serde.rs	95.45%	1 Missing ⚠️
src/naive/time/mod.rs	98.96%	1 Missing ⚠️
src/offset/fixed.rs	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            0.5.x    #1394      +/-   ##
==========================================
+ Coverage   93.51%   94.16%   +0.65%     
==========================================
  Files          34       34              
  Lines       17018    16824     -194     
==========================================
- Hits        15914    15842      -72     
+ Misses       1104      982     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pitdicker]

We may want to backport the first two commits (documentation and test fixes) to the 0.4 branch.

[djc]

We may want to backport the first two commits (documentation and test fixes) to the 0.4 branch.

That sounds good to me.

[djc]

I was wondering if it was better to rename the replacement methods at the same time as removing the deprecated methods, or to leave that for another PR. I.e. renaming things like FixedOffset::east_opt to FixedOffset::east.

Yes, I think we should do that in the same commit.

[pitdicker]

Because the renames are touching so many lines I split them out in separate commits. Easy to squash if you do prefer them combined though.

I don't really want to make a lot of changes to the file for NaiveDate because I think it would create a messy merge conflict the open PR to refactor that file. So I skipped the renames there for now.