[RELEASE] v6.0.0 #285
Merged
[RELEASE] v6.0.0 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenCover is Windows-only.
Also move coverage filters to external file.
The old boolean "Connected" field in the SDK has been changed to a DWORD specifying how many devices are connected. The SdkDeviceInfo struct in Colore has been updated to reflect this change. The field for the device count is renamed to "ConnectedCount" in Colore with a new helper property "Connected" to retain the old behaviour.
This effect is called CHROMA_CUSTOM2 in the SDK. It apparently supports newer keyboard models that presumably have a larger grid of keys. Updates #281.
* Upgrade Cake to 1.0.0 * Upgrade GitVersion to 5.6.6 * Remove unnecessary helper scripts * Upgrade other packages used in build script * Fix bug with ambiguous call in build script
Previously it was pointing to an external image URL, which is not as reliable.
If the SDK returns the ERROR_DEVICE_NOT_CONNECTED error when calling the QueryDevice API, do not throw a NativeCallException but instead detect this error and return a device info struct where the connected count is set to zero. A new enum member "Unknown" is added to the DeviceType enumeration to cover this use case. Fixes #284.
|
❌ Build Colore 227-eswcslgl failed (commit e633e1fb87 by @Sharparam) |
Issue with GitVersion when building PRs. See: GitTools/GitVersion#2554
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=========================================
Coverage ? 64.43%
=========================================
Files ? 74
Lines ? 1625
Branches ? 0
=========================================
Hits ? 1047
Misses ? 578
Partials ? 0 Continue to review full report at Codecov.
|
|
This looks good to me, me. Thanks me, I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sixth major release of Colore!
This is very long overdue and it includes a lot of changes.
Much of the API has been completely re-organized and is not backwards compatible, users of the library will need to update their code. The new locations should hopefully feel more logical though.
Major changes
API restructuring
The organization of the API felt off in many places, and has been adjusted to feel more natural. Hopefully everything should feel logical to our users. If there are any questions about this after the changes, don't be afraid to voice your concerns! Another breaking change would be unlikely very soon, but we will take any feedback into consideration.
Removal of WPF and WinForms extensions
As part of upgrading the project to support the SDK REST API and be async, the old extensions to enable integration with WPF and WinForms data classes were dropped. We will likely update these in the future to support the new version of Colore, but for now we felt like focusing on the main library.
Support for the SDK REST API
Colore v6.0 brings support for Razer's REST API for the Chroma SDK.
Async support
All APIs in Colore have been reworked to support the async/await pattern. This was partly done in order to better support the REST API. If there is a need, we may look into adding back the synchronous versions of the APIs, mainly for use with the native SDK.
Et.c...
Apart from the major points above, we have of course done bug fixes in general and added support for new things that have appeared in the SDK.
This is a big change, but we know a fair amount of people have been using the release candidates of 6.0 for a while so hopefully most of our core users are familiar with the changes.
Again, if you have any concerns, all feedback is appreciated! You may create an issue if you have bugs or feature requests, or visit the discussions for more general questions and concerns.
Fixes #284.