Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont overwrite Existing Files #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Zemoj
Copy link

@Zemoj Zemoj commented Jul 18, 2018

Fix for issue #11 without adding new features.

Fix for issue chrishuan9#11 without adding new features.
@spreadred
Copy link

spreadred commented Jul 19, 2018

I don't think this PR should be merged unless it is paired with a corresponding config option to either enable or disable this functionality.

Perhaps, this should be better tackled by adding a configuration option to determine whether to use recursion or not.

@Zemoj
Copy link
Author

Zemoj commented Jul 19, 2018

I'm not sure I know a reason it should ever be overwriting existing files? Under normal circumstances it would never come up.

@spreadred
Copy link

True, I can't think of a normal circumstance where the desired behavior is to overwrite existing files but since this has been the functionality (whether intended or not) since the beginning, perhaps other people are somehow taking advantage of this overwrite functionality for automation or some other functionality?

That's sorta the basis for my suggestion of adding a config option to control this.

@chrishuan9
Copy link
Owner

chrishuan9 commented Aug 8, 2018

I will merge this request as soon as I added the controls in the UI to enable / disable this functionality. I am currently swamped with personal things which don't allow me to spend any time on further improving / fixing the plugin. I'm not saying that I won't keep improving it but you will need to be a bit patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants