chore: bump #119
Merged
chore: bump #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for these PRs. Will check them out in a week or so as I am out at the moment. |
|
Also have to update asyncjobs/.github/workflows/test.yaml Line 8 in 0fea613 |
ripienaar
reviewed
Apr 8, 2024
ripienaar
reviewed
Apr 9, 2024
go.mod
Outdated
| @@ -1,52 +1,52 @@ | |||
| module github.com/choria-io/asyncjobs | |||
|
|
|||
| go 1.19 | |||
| go 1.22 | |||
There was a problem hiding this comment.
sorry I should have noticed this, this should be 1.21 if we are testing both 1.21 and 1.22
sorry about that
There was a problem hiding this comment.
I got that and put 1.21 and 1.22
There was a problem hiding this comment.
Yeah we're testing against 1.21 and 1.22 - good. But the go.mod declares minimal supported Go is 1.22 so the 1.21 test are failing.
ripienaar
approved these changes
Apr 9, 2024
|
Thanks! I'll review the other soon, still settling in after holiday break. Please sign commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped to latest versions. Tests passed