Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer #200

Closed

Conversation

mattwthompson
Copy link
Contributor

$ pip install versioneer
$ versioneer install

magic and then everything works in Python 3.12 (surely)

$ pip install versioneer
$ versioneer install
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@13af90b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

@mattwthompson
Copy link
Contributor Author

Aha .... but of course

    The following packages are incompatible
      ├─ dgl 1.1.2**  is installable with the potential options
      │  ├─ dgl 1.1.2 would require
      │  │  └─ python_abi 3.10.* *_cp310, which can be installed;
      │  ├─ dgl 1.1.2 would require
      │  │  └─ python_abi 3.11.* *_cp311, which can be installed;
      │  └─ dgl 1.1.2 would require
      │     └─ python_abi 3.9.* *_cp39, which can be installed;
      └─ python 3.12**  is not installable because there are no viable options
         ├─ python 3.12.0 would require
         │  └─ python_abi 3.12.* *_cp312, which conflicts with any installable versions previously reported;
         └─ python 3.12.0rc3 would require
            └─ _python_rc, which does not exist (perhaps a missing channel).

@mikemhenry
Copy link
Contributor

I've been going around updating versioneer as run into problems with it, have you played with the non-vendored method at all? It is "new" but seems more robust than manually having to update

@mattwthompson
Copy link
Contributor Author

I haven't done that myself - if anything I've seen people move to different solutions altogether, I think MDAnalysis uses https://pypi.org/project/versioningit/

For this PR, would you prefer

  1. Drop the 3.12 tests for now, trust the automation, and just hope stuff builds downstream
  2. Wait until conda-forge/dgl has 3.12 builds (?)
  3. Pull down DGL from another source (dglteam? PyPI?)
  4. Other options?

@mikemhenry
Copy link
Contributor

done in #220

@mikemhenry mikemhenry closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants