cppcheck fixes. No functional change.

chipsalliance · Mar 8, 2024 · 11bfe7a · 11bfe7a
1 parent 8ba494c
commit 11bfe7a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/verilated.cpp b/include/verilated.cpp
@@ -1220,7 +1220,7 @@ IData _vl_vsscanf(FILE* fp,  // If a fscanf
             inPct = true;
             inIgnore = false;
         } else if (!inPct && std::isspace(pos[0])) {  // Format spaces
-            while (std::isspace(pos[1])) pos++;
+            while (std::isspace(pos[1])) ++pos;
             _vl_vsss_skipspace(fp, floc, fromp, fstr);
         } else if (!inPct) {  // Expected Format
             _vl_vsss_skipspace(fp, floc, fromp, fstr);

diff --git a/include/verilated_cov.cpp b/include/verilated_cov.cpp
@@ -121,7 +121,7 @@ class VerilatedCovImp final : public VerilatedCovContext {
 
 public:
     // CONSTRUCTORS
-    VerilatedCovImp(VerilatedContext* contextp)
+    explicit VerilatedCovImp(VerilatedContext* contextp)
         : m_contextp{contextp} {}
     VL_UNCOPYABLE(VerilatedCovImp);
 

diff --git a/include/verilated_cov.h b/include/verilated_cov.h
@@ -165,7 +165,7 @@ class VerilatedCov final {
     /// Return default filename for the current thread
     static std::string defaultFilename() VL_MT_SAFE { return threadCovp()->defaultFilename(); }
     /// Write all coverage data to a file for the current thread
-    static void write(const std::string filename) VL_MT_SAFE { threadCovp()->write(filename); }
+    static void write(const std::string& filename) VL_MT_SAFE { threadCovp()->write(filename); }
     static void write() VL_MT_SAFE { write(defaultFilename()); }
     /// Clear coverage points (and call delete on all items) for the current thread
     static void clear() VL_MT_SAFE { threadCovp()->clear(); }