Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Data Vault in DCCM #1844

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[feat] Data Vault in DCCM #1844

merged 3 commits into from
Dec 18, 2024

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Dec 9, 2024

This change moves the information stored in the hardware datavault into a DCCM-backed datavault. Memory protections on the DCCM datavault will be added as a separate change later.

@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Dec 9, 2024
@mhatrevi mhatrevi force-pushed the vmhatre/datavault-in-dccm branch from b4c1654 to 1aee6fb Compare December 9, 2024 23:45
@mhatrevi mhatrevi changed the base branch from vmhatre/dccm-size-increase to main-2.x December 9, 2024 23:46
@mhatrevi mhatrevi marked this pull request as ready for review December 9, 2024 23:46
@mhatrevi mhatrevi requested review from Copilot and removed request for Copilot December 9, 2024 23:46
@mhatrevi mhatrevi force-pushed the vmhatre/datavault-in-dccm branch 3 times, most recently from a304341 to e0d80da Compare December 10, 2024 03:54
This change moves the information stored in the hardware datavault into a DCCM-backed datavault. Memory protections on the DCCM datavault will be added as a separate change later.
@mhatrevi mhatrevi force-pushed the vmhatre/datavault-in-dccm branch from e0d80da to 92c32ad Compare December 16, 2024 22:24
swenson
swenson previously approved these changes Dec 16, 2024
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few small nits

drivers/src/data_vault.rs Outdated Show resolved Hide resolved
drivers/src/memory_layout.rs Show resolved Hide resolved
rom/dev/README.md Outdated Show resolved Hide resolved
runtime/src/dice.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small comments

@mhatrevi mhatrevi enabled auto-merge (squash) December 18, 2024 03:25
@mhatrevi mhatrevi merged commit 824a384 into main-2.x Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants