WIP: adapt to HN8010TS

[jonkerj]

No description provided.

[jonkerj]

Hi there,

I made some changes to make your exporter work on Huawei HN8010 ONT's. I deliberately broke compatibility with the EG8145v5 there, so this should not be merged. The reason I broke compatibility with EG8145v5 is that HN8010 are very similar from the web-gui-scrape perspective, but have differences, and these could be addressed without repeating code too much.

If you like this idea of extending your project to different Huawei devices, I'd like your thoughts on what could be the best approach. I was thinking - but I'm just brainstorming here - feel free to shoot:

1. split huawei-webgui logic (Login, Logout, Session) into a shared package, use that as a field in model-specific Client (e.g. eg8145/hn8010).
2. generalize the http-request part where the pages/scripts are fetched, as it is already repitive in eg8145 right now and will be repeated much more for hn8010
3. something smart for the collector, maybe using an interface in the model specific types

[akhy]

@jonkerj Hi, thanks for the PR. Honestly I'm glad someone found it useful. eg8145 is the only model I own right now, so I created the lib after this model. Would love to generalize and extend it to support other models as well 😄

• Agree with your 1-2 points. I believe it's a must do to move this project forward 👍
• For point 3, are you suggesting to also generalize the exporter?

[akhy]

I'll check the PR to see the differences and find out which shared logic we can extract.

[jonkerj]

Hi @akhy, do you have any feedback?

[jonkerj]

hello?