Add --local-registry
and --tag
flags
#35
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context:
I need to build a custom srtool image because I need an OpenCL library for the compilation process, as such, I need to add the install command to the srtool image. I used
just build
there and noticed that it always tries to fetch the image from docker.io which is less than ideal.I've added the two flags in the title:
--local-registry
— allows users to use volumes to share the local registry with Docker, the idea is to speed up builds but in this case I'm not 100% sure it helps A TON--tag
— allows users to set the tag, this is useful if you're building your custom docker imageI've moved the
SRTOOL_TAG
env var OUT of the library since it is essentially hidden control flow when used there.We can also replace the tag flag with a split on
:
to detect a tag on a Docker image.