Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --local-registry and --tag flags #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmg-duarte
Copy link

Some context:

I need to build a custom srtool image because I need an OpenCL library for the compilation process, as such, I need to add the install command to the srtool image. I used just build there and noticed that it always tries to fetch the image from docker.io which is less than ideal.

I've added the two flags in the title:

  • --local-registry — allows users to use volumes to share the local registry with Docker, the idea is to speed up builds but in this case I'm not 100% sure it helps A TON
  • --tag — allows users to set the tag, this is useful if you're building your custom docker image

I've moved the SRTOOL_TAG env var OUT of the library since it is essentially hidden control flow when used there.
We can also replace the tag flag with a split on : to detect a tag on a Docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant