Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add createResource endpoint [DEV-4605][DEV-4636] #366

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

sownak
Copy link
Contributor

@sownak sownak commented Dec 9, 2024

  • add PUT /createResource endpoint
  • add GET /traits endpoint
  • add GET /methods endpoint
  • add GET /properties endpoint
  • deprecate PUT /create-resource endpoint

@ankurdotb
Copy link
Contributor

@sownak sownak changed the title feat: add createResource endpoint [DEV-4605] feat: add createResource endpoint [DEV-4605][DEV-4636] Dec 9, 2024
@ankurdotb
Copy link
Contributor

@DaevMithran
Copy link
Contributor

Great work!!

sownak and others added 3 commits December 13, 2024 09:09
* feat: Add updateResource endpoint and tests

* Updated with review comments

Signed-off-by: Sownak Roy <[email protected]>
Signed-off-by: Sownak Roy <[email protected]>
Signed-off-by: Sownak Roy <[email protected]>
src/controllers/resource.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
tests/did/validateDid.spec.ts Outdated Show resolved Hide resolved
tests/resource/createResource.spec.ts Outdated Show resolved Hide resolved
tests/resource/updateResource.spec.ts Outdated Show resolved Hide resolved
tests/resource/validateResource.spec.ts Outdated Show resolved Hide resolved
Eengineer1
Eengineer1 previously approved these changes Dec 17, 2024
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Approved.

@Eengineer1 Eengineer1 changed the base branch from main to develop December 17, 2024 15:18
@Eengineer1 Eengineer1 dismissed their stale review December 17, 2024 15:18

The base branch was changed.

@Eengineer1 Eengineer1 merged commit 25b5f59 into develop Dec 17, 2024
16 checks passed
@Eengineer1 Eengineer1 deleted the feat/updated-endpoints branch December 17, 2024 15:18
cheqd-bot bot pushed a commit that referenced this pull request Dec 17, 2024
## [2.3.0-develop.1](2.2.0...2.3.0-develop.1) (2024-12-17)

### Features

* add createResource endpoint [DEV-4605][DEV-4636] ([#366](#366)) ([25b5f59](25b5f59)), closes [#367](#367)
@cheqd-bot
Copy link

cheqd-bot bot commented Dec 17, 2024

🎉 This PR is included in version 2.3.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Jan 21, 2025
## [2.3.0](2.2.0...2.3.0) (2025-01-21)

### Features

* add createResource endpoint [DEV-4605][DEV-4636] ([#366](#366)) ([25b5f59](25b5f59)), closes [#367](#367)

### Bug Fixes

* Make did and relativeDidUrl optional ([#372](#372)) ([75ee35b](75ee35b))
* Store did in cache for resources ([#373](#373)) ([d601b62](d601b62))
@cheqd-bot
Copy link

cheqd-bot bot commented Jan 21, 2025

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants