Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix VS Code tests #488

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix: Fix VS Code tests #488

merged 4 commits into from
Jan 23, 2025

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Jan 20, 2025

What does this PR do?

At the moment Che-Code build fails on the VS Code tests іеуз with the following error:

Old Headless mode has been removed from the Chrome binary. Please use the new Headless mode

Arg --headless=new fixes the problem.

What issues does this PR fix?

eclipse-che/che#23315

How to test this PR?

all checks for the PR should be successful - so VS Code tests are passed for all assemblies

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Copy link

github-actions bot commented Jan 20, 2025

Click here to review and test in web IDE: Contribute

@RomanNikitenko RomanNikitenko added the made-with-che Changes made with Che-Code label Jan 20, 2025
@RomanNikitenko RomanNikitenko force-pushed the fix-tests branch 3 times, most recently from bc12a69 to a111e47 Compare January 22, 2025 17:14
Signed-off-by: Roman Nikitenko <[email protected]>
Signed-off-by: Roman Nikitenko <[email protected]>
Copy link

Signed-off-by: Roman Nikitenko <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
Copy link

@RomanNikitenko RomanNikitenko marked this pull request as ready for review January 23, 2025 11:53
Copy link

1 similar comment
Copy link

@RomanNikitenko RomanNikitenko merged commit c9ebb38 into main Jan 23, 2025
7 checks passed
@RomanNikitenko RomanNikitenko deleted the fix-tests branch January 23, 2025 13:04
@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1542: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes made with Che-Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants