Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ssh-askpass.sh script #453

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Improve the ssh-askpass.sh script #453

merged 1 commit into from
Nov 18, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Nov 13, 2024

What does this PR do?

Do the default vscode flow (get the passphrase from the inputbox) under next conditions:

  • If the passphrase file is missing.
  • If the passphrase is incorrect, for that we test the passphrase with the ssh-keygen.

What issues does this PR fix?

fixes eclipse-che/che#23244

How to test this PR?

see eclipse-che/che#23244

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Copy link

github-actions bot commented Nov 13, 2024

Click here to review and test in web IDE: Contribute

Copy link

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, with the PR changes system asks me to put a passphrase to confirm a git operation (I didn't provide a passphrase on the dashboard):

image

@vitaliy-guliy
Copy link
Contributor

I'm not able to start a workspace after adding the key pair to my account via User Preferences -> SSH keys

Screenshot from 2024-11-14 18-42-49

Tested on the dogfooding with and without changes provided by this PR.

@vinokurig
Copy link
Contributor Author

@vitaliy-guliy
If the issue is reproduced with default editor image, then it is not related to the pull request, could you please create an issue for that?

@vinokurig vinokurig merged commit 3d2e031 into main Nov 18, 2024
8 checks passed
@vinokurig vinokurig deleted the che-23244 branch November 18, 2024 07:24
@devspacesbuild
Copy link

Build 3.18 :: code_3.x/1500: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error is shown on a remote git operation from Che-code git extension
5 participants