chore: Align with upstream #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created two new settings to be added to .vscode/settings.json
('variableDisplayType.watchView' and
'variableDisplayType.variableView') when set
to true it shows the variable type in the
format var_name: type = value in the debug panel and variable panel
respectively and the hover will now display var_name.
When set to false uses the previous
expected behaviour (var_name = value)
and the hover will display the type.
Co-authored-by: Diogo Pinto <[email protected]>
Part of #145234
Fixes #193508
…312) * Make sure event subscriptions are stored and disposed (#214234) * fix tests
Part of #214234
Register more terminal listeners
* allow null value * allow unsetting color * undo change * delete color * undo changes * remove unused code * unset right map * add function to create nullable color schema * use nullable schema * undo change * fix nullable object * use default value * update both schemas on timeout * simplifications & polish --------- Co-authored-by: Martin Aeschlimann <[email protected]>
* register theme service * set color theme * set default snippet * remove log * use type import * fix formatting * undo change * remove log * fix formatting * rename interface * rename function * update listener * remove unused code * inline event listener * polish --------- Co-authored-by: Martin Aeschlimann <[email protected]>
colorUtils: fixing typing error caused by merging
* renames, test improvement * code improvements
Refs #214234
* Fix opening select boxes This fixes a regression caused by #213465 Closes #214303 Closes #214345 * Fix another regression caused by #213465 --------- Co-authored-by: Benjamin Pasero <[email protected]>
Follows up on #214234
* better lightbulb scenario for when we are very close to edge * fix and change logic for last line * clean up whitespace * helper func, check whitespace * remove extra model check * add new logic for when blocked above and below * remove whitespace
remove background from widget:
Fixes clipping of custom context menus in embedded editors, such as those in the chat view
terminal part of #215526
* Start breaking ChatListRenderer content types into their own classes * Make renderTextEdit a Part as well * Add ChatMarkdownContentPart * Layout codeblock refs
…ering (#215907)" (#216267) This reverts commit 85e9b07.
Revert ":up: `@parcel/[email protected]` (#215964)" This reverts commit 406d1d7.
Bumps [ws](https://github.com/websockets/ws) from 7.4.6 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.6...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
vscode-upstream-sha1: a8e00a0 rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
RomanNikitenko
requested review from
azatsarynnyy and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
azatsarynnyy
approved these changes
Jun 18, 2024
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-373-amd64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebase against the upstream
What issues does this PR fix?
eclipse-che/che#22965
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder