fix: projects are ignored when restarting workspace from local devfile #345

vitaliy-guliy · 2024-04-15T16:40:33Z

What does this PR do?

fixes disappearing the projects after updating the devfile
proposes the user to select the devfile if workspace contains several projects
decouples updating the devfile in a separate try {} catch {} section to better understanding the cause of the error when restarting the workpace

What issues does this PR fix?

eclipse-che/che#22722

How to test this PR?

Create a workspace with factory https://github.com/che-samples/java-spring-petclinic.git?che-editor=https://gist.githubusercontent.com/vitaliy-guliy/a2efd2a2e0f3324e057edab0ed7b2494/raw/05bac72e7318fc1edfe1e72e4e4dcabaa50a0ff3/editor.yaml&new

or just click at

Open the devfile in java-spring-petclinic project, add following section and save

projects:
  - name: nodejs-devfile-test
    git:
      remotes:
        origin: https://github.com/vitaliy-guliy/nodejs-devfile-test.git

  - name: lombok-project-sample
    git:
      remotes:
        origin: https://github.com/vitaliy-guliy/lombok-project-sample.git

Run Eclipse Che: Restart Workspace from Local Devfile command, select a devfile for java-spring-petclinic project and confirm restart.

Workspace should be restarted, explorer should contain three projects.

Install redhat.vscode-yaml extension.
Open the devfile in java-spring-petclinic project, add some environment variable to the tools container.

      env:
        - name: test
          value: test_value

Run Eclipse Che: Restart Workspace from Local Devfile command.

Select the devfile for java-spring-petclinic project and confirm restart to continue.
Once workspace is restarted, open the terminal and verify the environment variable is set.

Copy the devfile in java-spring-petclinic project to the new file with a different name.
Open newly created devfile, add another one environment variable like above and run Eclipse Che: Restart Workspace from Local Devfile command.
In a proposed popup select the last item and then using the popup open the created devfile.
Confirm restart when requested.

The workspace should be restarted. Open a terminal and check for environment variable.

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-15T16:40:45Z

Click here to review and test in web IDE:

github-actions · 2024-04-15T16:43:15Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-15T18:17:59Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-17T21:49:19Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-17T22:48:34Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-18T13:03:38Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-18T14:06:02Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-22T09:33:01Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-22T10:31:13Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-22T10:57:07Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-22T11:54:44Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-22T12:37:04Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-22T13:36:20Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-22T13:51:37Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-04-22T13:55:05Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-04-22T14:53:02Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

code/extensions/che-remote/src/extension.ts

RomanNikitenko · 2024-04-23T14:07:58Z

@vitaliy-guliy
I've tested the changes:

adding a project to the projects section works well for me
removing a project doesn't work

But, to be honest, I don't know how we should handle such cases...

RomanNikitenko · 2024-04-23T14:18:23Z

About eclipse-che/che#22913
Actually, I don't see that the behaviour was changed, I see the following message:

Dashboard handles similar problem by providing the following message:

vitaliy-guliy · 2024-04-24T15:33:08Z

removing a project doesn't work

But, to be honest, I don't know how we should handle such cases...

It is not clear what should we do if a user remove the project. That's why this behavior was omitted.

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-05-06T12:27:37Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-05-06T13:27:39Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-05-07T11:59:11Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-05-07T13:56:37Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-05-13T12:03:37Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-05-13T13:11:14Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

Signed-off-by: vitaliy-guliy <[email protected]>

github-actions · 2024-05-13T21:51:38Z

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-345-dev-amd64

github-actions · 2024-05-13T22:50:41Z

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-345-amd64

code/extensions/che-remote/src/extension.ts

fix: projects are ignored when restarting workspace from local devfile

320990e

Signed-off-by: vitaliy-guliy <[email protected]>

update

712b452

Signed-off-by: vitaliy-guliy <[email protected]>

update

1889da0

Signed-off-by: vitaliy-guliy <[email protected]>

update

670a8df

Signed-off-by: vitaliy-guliy <[email protected]>

update

7c0d779

Signed-off-by: vitaliy-guliy <[email protected]>

update

544fd6f

Signed-off-by: vitaliy-guliy <[email protected]>

update

5496e0d

Signed-off-by: vitaliy-guliy <[email protected]>

update

7602af4

Signed-off-by: vitaliy-guliy <[email protected]>

vitaliy-guliy marked this pull request as ready for review April 22, 2024 13:53

vitaliy-guliy requested review from azatsarynnyy and RomanNikitenko as code owners April 22, 2024 13:53

RomanNikitenko reviewed Apr 23, 2024

View reviewed changes

code/extensions/che-remote/src/extension.ts Show resolved Hide resolved

update

2603076

Signed-off-by: vitaliy-guliy <[email protected]>

update

f6c04e8

Signed-off-by: vitaliy-guliy <[email protected]>

vitaliy-guliy marked this pull request as draft May 6, 2024 22:46

update

b239f81

Signed-off-by: vitaliy-guliy <[email protected]>

vitaliy-guliy marked this pull request as ready for review May 7, 2024 13:55

vitaliy-guliy changed the title ~~[WIP] fix: projects are ignored when restarting workspace from local devfile~~ fix: projects are ignored when restarting workspace from local devfile May 7, 2024

update

b2354ec

Signed-off-by: vitaliy-guliy <[email protected]>

vitaliy-guliy added the made-with-che Changes made with Che-Code label May 13, 2024

remove extra output

724450d

Signed-off-by: vitaliy-guliy <[email protected]>

RomanNikitenko reviewed May 14, 2024

View reviewed changes

code/extensions/che-remote/src/extension.ts Show resolved Hide resolved

RomanNikitenko approved these changes May 14, 2024

View reviewed changes

vitaliy-guliy merged commit a67cd09 into main May 14, 2024
7 checks passed

vitaliy-guliy deleted the restart-from-local-devfile branch May 14, 2024 07:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: projects are ignored when restarting workspace from local devfile #345

fix: projects are ignored when restarting workspace from local devfile #345

vitaliy-guliy commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

RomanNikitenko commented Apr 23, 2024

RomanNikitenko commented Apr 23, 2024 •

edited

Loading

vitaliy-guliy commented Apr 24, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

fix: projects are ignored when restarting workspace from local devfile #345

fix: projects are ignored when restarting workspace from local devfile #345

Conversation

vitaliy-guliy commented Apr 15, 2024 • edited Loading

What does this PR do?

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

github-actions bot commented Apr 15, 2024 • edited Loading

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 17, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

RomanNikitenko commented Apr 23, 2024

RomanNikitenko commented Apr 23, 2024 • edited Loading

vitaliy-guliy commented Apr 24, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 6, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 7, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 13, 2024

vitaliy-guliy commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

RomanNikitenko commented Apr 23, 2024 •

edited

Loading