chore: Align with upstream #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #181900
Part of #181900
Continuation of microsoft/vscode#193937 and microsoft/vscode#197442 This adds the command descriptions of editor actions to the ICommandQuickPick results so that those results can be picked up by the "similar commands" feature. Example: I can add: ``` metadata: { description: nls.localize2('test', "xyz"), } ``` to the [AddLineCommentAction](https://github.com/microsoft/vscode/blob/7d788e70b95c79718b565ff9e255858db4cc74b3/src/vs/editor/contrib/comment/browser/comment.ts#L105)... and then when I search "xyz" it'll show up.
Use IconSelectBox to change terminal icon, remove dupes
This is important information for the command so we should include it in this response.
Introduce ITerminalConfigurationService, move TerminalConfigHelper.config to it
move speech accessibility signals to contribution file
* Fix injected services becoming public by mistake Fixes cases of `@IFooService readonly foo: IFooService`. This makes the service public, which is likely not expected and also means we can't mangle it * Fix name * Remove unused props
- use diff editor hiding of unchanged regions - simpler code compare block (for now)
fixes #209164
…nk (#209532) fixes #207003
* first snap * sent the comments to the shadow realm * one comment we forgot to remove :(
Add support for `ChatResponseTextEditPart`
vscode-upstream-sha1: a52d0d9 rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request Dev image published: |
|
Pull Request Che-Code image published: |
RomanNikitenko
requested review from
azatsarynnyy,
vitaliy-guliy and
l0rd
as code owners
azatsarynnyy
approved these changes
Apr 8, 2024
vitaliy-guliy
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rebase against the upstream
What issues does this PR fix?
eclipse-che/che#22905
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder