fix: set /project as default pah for the terminal
#330
Conversation
Signed-off-by: vitaliy-guliy <[email protected]>
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request Dev image published: |
| @@ -1,5 +1,6 @@ | |||
| { | |||
| // Note: settings in this file will override user-level settings in the workspace. | |||
| // Any setting that may be changed by the user should not be set here. | |||
| "git.defaultCloneDirectory": "/projects/" | |||
| "git.defaultCloneDirectory": "/projects/", | |||
| "terminal.integrated.cwd": "/projects/" | |||
There was a problem hiding this comment.
@vitaliy-guliy
could you test the use case when a workspace is not empty, so contains a project
I guess the /projects will be a directory in the terminal
There was a problem hiding this comment.
This pull request is created exactly to test the case.
There was a problem hiding this comment.
Have just tested the case. The settings force the terminal always switch to /projects, even if the project is opened.
There was a problem hiding this comment.
This pull request is created exactly to test the case
you are working on the issue related to an empty workspace
so, I thought that you were going to test it for an empty workspace
I proposed to test it for another use case to avoid a regression...
There was a problem hiding this comment.
You can create a directory with mkdir /protects/test-dir, goto Open Folder and pick /projects/test-dir.
Then open a terminal and check the working directory.
It will be always /projects despite your workspace is not empty.
There was a problem hiding this comment.
Seems #328 is a solution for us
|
Pull Request Che-Code image published: |
What does this PR do?
What issues does this PR fix?
How to test this PR?