Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix activation of the Eclipse Che Terminal extension #288

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: Fix activation of the Eclipse Che Terminal extension #288

merged 1 commit into from
Oct 31, 2023

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Oct 30, 2023 •
edited
Loading

What does this PR do?

Fixes an error: TypeError: s is not a constructor at the activation of the Eclipse Che Terminal extension step

What issues does this PR fix?

eclipse-che/che#22611

How to test this PR?

Please see Steps to reproduce section of the issue: eclipse-che/che#22611

@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-288-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-288-dev-amd64

@RomanNikitenko RomanNikitenko added the made-with-che Changes made with Che-Code label Oct 30, 2023
@RomanNikitenko RomanNikitenko merged commit df74071 into main Oct 31, 2023
@RomanNikitenko RomanNikitenko deleted the fix-terminal-extension-activation branch October 31, 2023 05:19
@devstudio-release
Copy link

Build 3.10 :: code_3.10/9: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: code_3.x/966: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: code_3.10/10: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: code_3.x/967: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: code_3.10/10: UNSTABLE

Upstream sync done; No sync or Brew build

@devstudio-release
Copy link

Build 3.11 :: code_3.x/967: UNSTABLE

Upstream sync done; No sync or Brew build

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.10/74: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5140: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.10/73: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: push-latest-container-to-quay_3.10/39: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.10/73: SUCCESS

code : 3.10 :: Build 56640332 : quay.io/devspaces/code-rhel8:3.10-85
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.10/39 triggered

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.10/68: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: code_3.10/9: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.10/74 triggered

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.10/24: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.10/76: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.10/75: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: push-latest-container-to-quay_3.10/40: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.10/75: SUCCESS

devspaces-operator-bundle : 3.10 :: Build 56641114 : quay.io/devspaces/devspaces-operator-bundle:3.10-180
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.10/40 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.10-85
- quay.io/devspaces/configbump-rhel8:3.10-18
- quay.io/devspaces/dashboard-rhel8:3.10-42
- quay.io/devspaces/devfileregistry-rhel8:3.10-79
- quay.io/devspaces/devspaces-rhel8-operator:3.10-21
- quay.io/devspaces/idea-rhel8:3.10-6
- quay.io/devspaces/pluginregistry-rhel8:3.10-17
- quay.io/devspaces/server-rhel8:3.10-22
- quay.io/devspaces/traefik-rhel8:3.10-10
- quay.io/devspaces/udi-rhel8:3.10-10
- quay.io/devspaces/udi-rhel8:3.10-17
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202310170157.p0.g94f3fde.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202310170157.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.10/76: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.10/75 triggered; /job/DS_CI/job/dsc_3.10 triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.10/24: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.10/76 triggered

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/2039: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.10/68: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.10/24 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.10/15: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/2039: SUCCESS

3.10
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.10-180
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.10-181
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-611892-533291-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-611889-533286-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-612038-533281-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-x86_64
  + quay.io/devspaces/iib:latest-v4.12-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-612017-533277-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-x86_64
  + quay.io/devspaces/iib:latest-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-611892-533291-ppc64le
  + quay.io/devspaces/iib:3.10-v4.14-ppc64le
  + quay.io/devspaces/iib:latest-v4.14-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-611889-533286-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-ppc64le
  + quay.io/devspaces/iib:latest-v4.13-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-612038-533281-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-ppc64le
  + quay.io/devspaces/iib:latest-v4.12-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-612017-533277-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-ppc64le
  + quay.io/devspaces/iib:latest-v4.11-ppc64le
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-611892-533291-s390x
  + quay.io/devspaces/iib:3.10-v4.13-611889-533286-s390x
  + quay.io/devspaces/iib:3.10-v4.12-612038-533281-s390x
  + quay.io/devspaces/iib:3.10-v4.12-s390x
  + quay.io/devspaces/iib:latest-v4.12-s390x
  + quay.io/devspaces/iib:3.10-v4.11-612017-533277-s390x
  + quay.io/devspaces/iib:3.10-v4.11-s390x
  + quay.io/devspaces/iib:latest-v4.11-s390x

@devstudio-release
Copy link

Build 3.11 :: code_3.x/968: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5180: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5069: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3608: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5069: SUCCESS

code : 3.x :: Build 56760902 : quay.io/devspaces/code-rhel8:3.11-4
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3608 triggered

@devstudio-release
Copy link

Build 3.11 :: code_3.x/968: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5180 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4812: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2257: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5185: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5070: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: push-latest-container-to-quay_3.x/3609: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2092: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5070: SUCCESS

devspaces-operator-bundle : 3.x :: Build 56760931 : quay.io/devspaces/devspaces-operator-bundle:3.11-32
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3609 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.11-4
- quay.io/devspaces/configbump-rhel8:3.11-3
- quay.io/devspaces/dashboard-rhel8:3.11-15
- quay.io/devspaces/devfileregistry-rhel8:3.11-15
- quay.io/devspaces/devspaces-rhel8-operator:3.11-6
- quay.io/devspaces/idea-rhel8:3.11-3
- quay.io/devspaces/pluginregistry-rhel8:3.11-3
- quay.io/devspaces/server-rhel8:3.11-4
- quay.io/devspaces/traefik-rhel8:3.11-3
- quay.io/devspaces/udi-rhel8:3.11-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202310241244.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202310201022.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5185: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5070 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2257: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5185 triggered

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4812: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/2257 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1524: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1524: SUCCESS

3.11.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
made-with-che Changes made with Che-Code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanNikitenko @devstudio-release @azatsarynnyy